Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This descibes possible causes for a rare crasher with effects. #4487

Closed
wants to merge 14 commits into from
Closed

This descibes possible causes for a rare crasher with effects. #4487

wants to merge 14 commits into from

Conversation

daschuer
Copy link
Member

I have experienced a crasher during testing of #2618

Probably related:
https://bugs.launchpad.net/mixxx/+bug/1775497

Here is the log, unfortunately it has not happen to me under GDB.

QML debugging is enabled. Only use this in a safe environment.
Loading resources from  "/home/daniel/workspace/2.3/res/"
Configuration file is at version "2.3.0-beta" instead of the current "2.4.0-alpha-pre"
BroadcastSettings - Found 1 profile(s)
Loading resources from  "/home/daniel/workspace/2.3/res/"
Found and will use default keyboard mapping "/home/daniel/workspace/2.3/res/keyboard/en_US.kbd.cfg"
Loading resources from  "/home/daniel/workspace/2.3/res/"
Loaded skin "Shade"
DBus screensaver  org.freedesktop.ScreenSaver  inhibited
ALSA lib pcm.c:2642:(snd_pcm_open_noupdate) Unknown PCM cards.pcm.rear
ALSA lib pcm.c:2642:(snd_pcm_open_noupdate) Unknown PCM cards.pcm.center_lfe
ALSA lib pcm.c:2642:(snd_pcm_open_noupdate) Unknown PCM cards.pcm.side
ALSA lib pcm_route.c:869:(find_matching_chmap) Found no matching channel map
ALSA lib pcm_route.c:869:(find_matching_chmap) Found no matching channel map
ALSA lib pcm_route.c:869:(find_matching_chmap) Found no matching channel map
ALSA lib pcm_route.c:869:(find_matching_chmap) Found no matching channel map
Cannot connect to server socket err = Datei oder Verzeichnis nicht gefunden
Cannot connect to server request channel
jack server is not running or cannot be started
JackShmReadWritePtr::~JackShmReadWritePtr - Init not done for -1, skipping unlock
JackShmReadWritePtr::~JackShmReadWritePtr - Init not done for -1, skipping unlock
Cannot connect to server socket err = Datei oder Verzeichnis nicht gefunden
Cannot connect to server request channel
jack server is not running or cannot be started
JackShmReadWritePtr::~JackShmReadWritePtr - Init not done for -1, skipping unlock
JackShmReadWritePtr::~JackShmReadWritePtr - Init not done for -1, skipping unlock
ALSA lib pcm_oss.c:377:(_snd_pcm_oss_open) Unknown field port
ALSA lib pcm_oss.c:377:(_snd_pcm_oss_open) Unknown field port
ALSA lib pcm_usb_stream.c:486:(_snd_pcm_usb_stream_open) Invalid type for card
ALSA lib pcm_usb_stream.c:486:(_snd_pcm_usb_stream_open) Invalid type for card
Cannot connect to server socket err = Datei oder Verzeichnis nicht gefunden
Cannot connect to server request channel
jack server is not running or cannot be started
JackShmReadWritePtr::~JackShmReadWritePtr - Init not done for -1, skipping unlock
JackShmReadWritePtr::~JackShmReadWritePtr - Init not done for -1, skipping unlock
warning [Main] Library - Skipping access check for missing or invalid directory QFileInfo(/home/daniel/Öffen)
warning [BrowseThread] MetadataSourceTagLib - Cannot import track metadata from file "/home/daniel/Musik/Mixxx/Recordings/2021-03-16_15h27m08s.aac" with unknown or unsupported type 0
warning [BrowseThread] MetadataSourceTagLib - Cannot import track metadata from file "/home/daniel/Musik/Mixxx/Recordings/2021-03-16_15h26m32s.aac" with unknown or unsupported type 0
warning [BrowseThread] MetadataSourceTagLib - Cannot import track metadata from file "/home/daniel/Musik/Mixxx/Recordings/2021-03-16_15h26m02s.aac" with unknown or unsupported type 0
warning [Main] ControlDoublePrivate::getControl returning NULL for ( "[Master]" , "skin_settings" )
Abgebrochen (Speicherabzug geschrieben)

This was referenced Oct 26, 2021
Closed
Merged
Be-ing
Be-ing suggested changes Oct 26, 2021
View reviewed changes
Copy link
Contributor

@Be-ing Be-ing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding speculative and potentially misleading comments to the code is not okay or helpful. We have a bug report already. Speculation about the causes of bugs belong on the bug tracker, not source code comments.

@daschuer
Copy link
Member Author

It was part of our commitment to add TODOs,
to the code. That is what I have done.

It would be OK that we don't merge it an fix the issue instead. The comment in the code will help others if they experience the issue to find the related bug report, in case we release 2.4 without a fix.

Do you have interest to investigate it?

Maybe we can delay the merge until you have an idea what really causes the issue.

@Be-ing
Copy link
Contributor

Be-ing commented Oct 27, 2021

Fixing the issue would be great. But first we need to know how to reproduce it and figure out the cause. These comments may turn out to be irrelevant to the cause.

@daschuer
Copy link
Member Author

These comments may turn out to be irrelevant to the cause.

But they still work for the purpose outlined above. They summarize the results of my investigations.

Do you have interest to investigate it?

Do you? If so, this discussion is mood. But it will be relevant if you decide step of of this task.

@github-actions
Copy link

This PR is marked as stale because it has been open 90 days with no activity.

@github-actions github-actions bot added the stale Stale issues that haven't been updated for a long time. label Jan 26, 2022
@daschuer daschuer mentioned this pull request Feb 15, 2022
Merged
@daschuer daschuer force-pushed the effects_refactoring_2 branch from 3a283b0 to 36fbe82 Compare March 16, 2022 08:18
daschuer added 12 commits March 16, 2022 11:04
@daschuer
Remove unused function EnginEffectChain::getChannelStatus()
027ddee
@daschuer
Avoid write access via reference
fd60cf9
@daschuer
Add ChannelHandleMap::isEmpty()
e379844
@daschuer
Pass ChannelHandleAndGroup instead of just the group name to avoid ha…
b019fa7 
…ndle lookup
@daschuer
Move the skin warning before the assertion
f5bb9a1
@daschuer
Enable the effects AFTER we have added effect slots
5663ae2
@daschuer
extend scope for a better readability
895a7e8
@daschuer
Introduce an updateActiveState() function to be able to clean up buff…
2d2bb6c 
…ers after a channel has been disabled.
@daschuer
process one more buffer after eject
dff90d2
@daschuer
Use the fadeout flag to fade down and initialize the effect buffers w…
b5a9ef6 
…hen a stream is paused. Fixes lp1966607
@daschuer
EffectProcessor: split out initalizeChannelHandle
339acee
@daschuer
Don't delete effect state object when chain is disabled. From the use…
6fbe3da 
…r perspective it is no difference between disabling an effect or a chain.
@daschuer daschuer mentioned this pull request Mar 29, 2022
Merged
@daschuer
Copy link
Member Author

Superseded by #4707

@daschuer daschuer closed this Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Be-ing Be-ing Be-ing requested changes

Assignees
No one assigned
Labels
code quality stale Stale issues that haven't been updated for a long time. ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daschuer @Be-ing